fix: equality for some domain classes #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
==========================================
+ Coverage 92.89% 93.43% +0.53%
==========================================
Files 64 64
Lines 3028 3048 +20
==========================================
+ Hits 2813 2848 +35
+ Misses 215 200 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jooola
changed the title
Member
|
Looking good :) Can we enforce this through a linter? |
Member
Author
|
Sadly not easily, and not sure I want to do meta class magic for this. |
jooola
pushed a commit
that referenced
this pull request
Jul 9, 2025
<!-- section-start changelog --> ### Bug Fixes - typo in `LoadBalancerHealthCheckHttp` class name (#511) - equality for some domain classes (#510) - use valid license identifier (SPDX) (#514) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ```rp-prefix ``` ### Suffix / End This will be added to the end of the release notes. ```rp-suffix ``` </details> Co-authored-by: Hetzner Cloud Bot <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some domains were missing the
__api_properties__and__slots__properties required for the equality check.